Fix design and implementation smells#66
Open
sanifalimomin wants to merge 17 commits intoJavaChat:masterfrom
Open
Fix design and implementation smells#66sanifalimomin wants to merge 17 commits intoJavaChat:masterfrom
sanifalimomin wants to merge 17 commits intoJavaChat:masterfrom
Conversation
sanifalimomin
changed the title
mangstadt
reviewed
Nov 28, 2025
mangstadt
reviewed
Nov 28, 2025
mangstadt
reviewed
Nov 28, 2025
added 2 commits
November 28, 2025 19:56
Remove logging function and revert it to earlier
mangstadt
reviewed
Nov 29, 2025
fixx long diff
mangstadt
reviewed
Nov 29, 2025
added 3 commits
November 29, 2025 18:46
mangstadt
reviewed
Nov 30, 2025
mangstadt
reviewed
Nov 30, 2025
mangstadt
reviewed
Nov 30, 2025
mangstadt
reviewed
Dec 2, 2025
mangstadt
reviewed
Dec 2, 2025
mangstadt
reviewed
Dec 2, 2025
mangstadt
reviewed
Dec 2, 2025
mangstadt
reviewed
Dec 2, 2025
mangstadt
reviewed
Dec 2, 2025
mangstadt
reviewed
Dec 2, 2025
mangstadt
reviewed
Dec 2, 2025
mangstadt
reviewed
Dec 2, 2025
added 2 commits
December 1, 2025 22:29
mangstadt
reviewed
Dec 5, 2025
| */ | ||
| public class Shutdown implements ChatAction { | ||
| //empty | ||
| //empty |
Member
There was a problem hiding this comment.
One last thing: Can you please convert these spaces back to a tab? This file shouldn't be showing up in the PR diff because it wasn't modified.
mangstadt
added a commit
that referenced
this pull request
Dec 20, 2025
Author: https://github.com/sanifalimomin See also: #66
mangstadt
added a commit
that referenced
this pull request
Dec 20, 2025
Author: https://github.com/sanifalimomin See also: #66
mangstadt
added a commit
that referenced
this pull request
Dec 20, 2025
Author: https://github.com/sanifalimomin See also: #66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fixed few of design and Implementation smells on most common used files.